Updated the style for GUI to move down when the console is open#201
Updated the style for GUI to move down when the console is open#201
Conversation
|
Old: New: 
|
alexanderbock
changed the title
|
We should be able to use the |
|
|
||
| const consoleOpen = useAppSelector((state) => state.properties.properties[LuaConsoleIsVisibleKey]?.value) as boolean | undefined; | ||
| const historyLength = useAppSelector((state) => state.properties.properties[LuaConsoleLengthKey]?.value) as number | undefined; | ||
| const consoleTop = historyLength ? historyLength*16 + 36 : 35; |
There was a problem hiding this comment.
| const consoleTop = historyLength ? historyLength*16 + 36 : 35; | |
| const consoleTop = historyLength ? historyLength * 16 + 36 : 35; |
There was a problem hiding this comment.
Haven't checked but we should double check that this works on multiple resolutions so its not a one type of monitor size that it looks good on
| const consoleOpen = useAppSelector((state) => state.properties.properties[LuaConsoleIsVisibleKey]?.value) as boolean | undefined; | ||
| const historyLength = useAppSelector((state) => state.properties.properties[LuaConsoleLengthKey]?.value) as number | undefined; |
There was a problem hiding this comment.
| const consoleOpen = useAppSelector((state) => state.properties.properties[LuaConsoleIsVisibleKey]?.value) as boolean | undefined; | |
| const historyLength = useAppSelector((state) => state.properties.properties[LuaConsoleLengthKey]?.value) as number | undefined; | |
| const consoleOpen = usePropertyValue('BoolProperty', 'LuaConsole.IsVisible'); | |
| const historyLength = usePropertyValue('IntProperty', 'LuaConsole.HistoryLength'); |
|
|
||
| export const LuaConsoleIsVisibleKey = 'LuaConsole.IsVisible'; | ||
| export const LuaConsoleLengthKey = 'LuaConsole.HistoryLength'; |
There was a problem hiding this comment.
| export const LuaConsoleIsVisibleKey = 'LuaConsole.IsVisible'; | |
| export const LuaConsoleLengthKey = 'LuaConsole.HistoryLength'; |
I think we've decided to define these strings locally unless it its being used in multiple places and or is a more complex identifier. See suggestion below
|
|
||
| import 'rc-dock/dist/rc-dock-dark.css'; | ||
| import './WindowLayout.css'; | ||
| import { LuaConsoleIsVisibleKey, LuaConsoleLengthKey } from '@/util/keys'; |
There was a problem hiding this comment.
| import { LuaConsoleIsVisibleKey, LuaConsoleLengthKey } from '@/util/keys'; |
| @@ -4,7 +4,7 @@ import DockLayout, { DockContext, LayoutData, PanelData, TabGroup } from 'rc-doc | |||
| import { FlightController } from '@/panels/FlightControlPanel/FlightController'; | |||
There was a problem hiding this comment.
| import { FlightController } from '@/panels/FlightControlPanel/FlightController'; | |
| import { usePropertyValue } from '@/hooks/properties'; | |
| import { FlightController } from '@/panels/FlightControlPanel/FlightController'; |
|
I know we talked about this but it looks a bit funky when you don't have any history. 
|
|
Looks good to me except when the history is not max. Also the code needs a |
|
I realized that we can scale the UI which makes this a bit tricky as it calculates pixels 🤔 |
Yeah, this is problematic, and computing the diff in pixels this way seems pretty fragile. Also, for me, the offset is not correct even without any change to the scaling, unfortunately :/ Not sure why this is 
There are also some other issues that emerged when testing this. For instance, changing the "History length" property affects the offset in an undesired way. Changing this makes it possible to accidentally completely hide the UI, which could be very confusing to our users. They would have to hide the Lua console to make the UI show again, which is not obvious (at least with these offset issues) Also, the "Backspace character" and tabbing does not work correctly in the Web UI when the Lua console is open. So, you can't type in the text field in the UI or navigate properly when the Lua console is open. This is a bug (that should be fixed), but I think it might also be a reason to not encourage users to use the UI with the Lua console open, at least for now. So, I would suggest that we close this for now, unfortunately, due to the issues above and the fragility of the solution. The idea is nice, and maybe we could reimplement it in the future, if we have fixed the issues with keyboard input capturing, and have a way of sending the relative size of the Lua console to the GUI or something. That way, we could avoid the issues of the miscomputed offset |
|
"we close this for now, unfortunately, due to the issues above and the fragility of the solution" agreed |
|
closing; see earlier comments |
4 participants
Previously the gui would stay behind the console when it was open, now it ducks underneath the console the way that the dashboard does.
While I guess it's not ideal that this will still happen if you have the gui open in a browser, it seems like its still nice to have for the main openspace use.